Hide verbose SSH connect output, add spinners#4694
Merged
Conversation
anton-107
requested review from
andrewnester,
denik,
pietern,
shreyas-goenka and
simonfaltum
as code owners
anton-107
force-pushed
the
ssh-connect-ux-spinners
branch
from
284aa8e to
9b4dc5d
Compare
3 tasks
Move detailed diagnostic messages (SSH key paths, secrets scope, remote user/port, job submission details, upload progress) from cmdio.LogString to log.Infof so they only appear with --log-level=info. Add spinners for long-running operations: binary upload, cluster state check, job startup wait, and metadata polling. Keep concise user-facing step messages (Connecting, Uploading, Starting, Connected) for progress visibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
anton-107
force-pushed
the
ssh-connect-ux-spinners
branch
from
9b4dc5d to
f5a32d5
Compare
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 6b48dad
18 interesting tests: 9 SKIP, 7 KNOWN, 1 flaky, 1 RECOVERED
Top 20 slowest tests (at least 2 minutes):
|
simonfaltum
approved these changes
Mar 12, 2026
Member
simonfaltum
left a comment
simonfaltum
left a comment
There was a problem hiding this comment.
[Agent Swarm Review] Verdict: Approved
- 0 Critical
- 0 Major
- 0 Gap
- 1 Nit
- 1 Suggestion
Good change. Moving diagnostic messages from cmdio.LogString to log.Infof and adding spinners for long-running operations improves the user experience. One nit on inconsistent spinner cleanup pattern.
| sp.Update("Uploading binaries...") | ||
| if err := UploadTunnelReleases(ctx, client, version, opts.ReleasesDir); err != nil { | ||
| sp.Close() | ||
| return fmt.Errorf("failed to upload ssh-tunnel binaries: %w", err) |
Member
There was a problem hiding this comment.
[Agent Swarm Review] [Nit]
The spinner for binary upload creates and closes inline rather than using defer sp.Close(). An early return between sp := cmdio.NewSpinner(ctx) and sp.Close() would leak the spinner. The other spinners in this PR correctly use defer sp.Close().
Suggestion: Move sp.Close() to a defer and remove the explicit close calls.
Contributor
Author
There was a problem hiding this comment.
Fixed! Consolidated to a single sp.Close() call after UploadTunnelReleases returns (before checking the error). I didn't use defer here since the spinner should close before ensureSSHServerIsRunning which creates its own spinners. Also applied defer sp.Close() in ensureSSHServerIsRunning which had the same pattern.
ilia-db
reviewed
Mar 13, 2026
| } | ||
|
|
||
| cmdio.LogString(ctx, fmt.Sprintf("Job submitted successfully with run ID: %d", waiter.RunId)) | ||
| log.Infof(ctx, "Job submitted successfully with run ID: %d", waiter.RunId) |
Contributor
There was a problem hiding this comment.
Job run ID can be very useful for debugging (and cluster id too actually)
And the problem is that we can't really get them after the fact (unless we also store local logs to a file, which we don't do right now)
Contributor
Author
There was a problem hiding this comment.
Good point — changed this back to cmdio.LogString so the run ID is always visible to users.
- Use single sp.Close() after UploadTunnelReleases instead of duplicated calls - Use defer sp.Close() in ensureSSHServerIsRunning for consistent cleanup - Keep job run ID in cmdio.LogString so it's visible without --log-level=info Co-authored-by: Isaac
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilia-db
approved these changes
Mar 17, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Summary - Add `WithElapsedTime()` construction option to the spinner that shows a running `MM:SS` stopwatch as a prefix - The elapsed time is displayed as a prefix (e.g., `00:15 ⣾ Starting SSH server...`) so it stays pinned to the left as the message changes - Time starts at spinner construction — no separate method call needed - The elapsed time updates on every spinner tick (200ms) with no extra goroutines - Enable it for all SSH connect spinners (binary upload, cluster check, job startup, metadata polling) Stacked on #4694 ## Test plan - [x] Run `databricks ssh connect` and verify elapsed time appears as a prefix and ticks next to each spinner - [x] Verify other spinners in the codebase (without `WithElapsedTime()`) are unaffected - [x] Verify the time stays stable on the left as the spinner message changes 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Commit: 9df759a
31 interesting tests: 16 RECOVERED, 9 KNOWN, 4 flaky, 1 FAIL, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmdio.LogStringtolog.Infofso they only appear with--log-level=infoConnecting to <id>...,Uploading binaries...,Starting SSH server...,Connected!) for progress visibilitycmdio.LogString) since it's useful for debuggingResolves DECO-26523
Test plan
databricks ssh connectand verify only concise step messages + spinners are shown--log-level=infoand verify detailed messages appear🤖 Generated with Claude Code